Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update interdependent dependencies and revise command-line interface #94

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

gwhitney
Copy link
Collaborator

Updates click, Flask and several of its extensions, itsdangerous, Jinja2,
MarkupSafe, SQLAlchemy, and Werkzeug.

Removes the obsolete Flask-Script extension, as that has been superseded
by the built-in Flask command-line interface flask <COMMAND> ...

NOTE: interacting with the server must henceforth occur just
with the new flask <COMMAND> ... interface.
Updates the docs to remove all references to manage.py.
Reimplements python manage.py test as flask test.
Makes progress on #43.
Supersedes #63.
Supersedes #90.

dependabot bot and others added 2 commits October 22, 2023 22:30
Bumps [flask](https://github.com/pallets/flask) from 1.1.4 to 2.2.5.
- [Release notes](https://github.com/pallets/flask/releases)
- [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst)
- [Commits](pallets/flask@1.1.4...2.2.5)

---
updated-dependencies:
- dependency-name: flask
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…erface

  Updates click, Flask and several of its extensions, itsdangerous, Jinja2,
  MarkupSafe, SQLAlchemy, and Werkzeug.

  Removes the obsolete Flask-Script extension, as that has been superseded
  by the built-in Flask command-line interface `flask <COMMAND> ...`
  Reimplements `python manage.py test` as `flask test`.
  Makes progress on numberscope#43.
  Supersedes numberscope#63.
  Supersedes numberscope#90.
@gwhitney
Copy link
Collaborator Author

Even though the primary point here is "just" to update dependencies, and the test did still run correctly for me, there have been pretty significant changes under the hood, to the extent that the old "manage.py" setup for interacting with the server has been eliminated. Hence this definitely needs manual review and testing by another party before it should be merged. And note (while testing and after merging this) we all need to shift to use flask <COMMAND> ... to manipulate the backscope (the Flask-Script extension that supported manage.py was retired between our old version of Flask and the current one). Thanks!

Copy link
Member

@katestange katestange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed the dependencies, ran flask run and flask test as well as the various flask db commands, and all appeared to be working (although I didn't blow away the database, so I was just checking they appear to call the right things, even though they told me I already had a migration etc.). There's one typo I pointed out. Do I need to anything else?

doc/tests.md Outdated Show resolved Hide resolved
@gwhitney
Copy link
Collaborator Author

Fixed the typo. If you have done the pip install and can run everything, and the backscope works on your machine when you run it, and you've reviewed the code changes (as seems clear by catching the typo), then no, I can't think of anything else you need to do. Thanks!

@katestange katestange merged commit cc4d071 into numberscope:main Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants